aws / aws/aws-cli

aws cloudformation deploy does not clean up failed change set

Open
#4,534 18 comments 83 reactions 0 assignees View on GitHub
cloudformation package-deploy customization enhancement feature-request p2
Dominant language
Python
Stars
17.3k
Forks
4.6k
Avg merge
1d 2h
Merged PRs (30d)
13

Description

I'm using `aws cloudformation deploy` in a CI/CD pipeline with the option `--no-fail-on-empty-changeset`. This allows the pipeline to deploy all stacks, no matter if there was a change to the template or parameters.

However, `aws cloudformation deploy` with the option `--no-fail-on-empty-changeset` does create a change set which goes to state `FAILED` with reason `The submitted information didn't contain changes. Submit different information to create a change set.`. The problem is, that the failed change set does not get deleted. Therefore, hundreds of change sets pile up. Resulting in an `LimitExceededException` (`ChangeSet limit exceeded for stack ...`) after a while.

In my opinion, `aws cloudformation deploy` with option `--no-fail-on-empty-changeset` should delete change sets, that failed because of an empty change set. Or there should at least be an option to do so.

Contributor guide

Open the contributing guide

Research direction

Start at the aws cloudformation deploy entry point and reproduce the behavior with --no-fail-on-empty-changeset in a stack with no changes. Trace how the failed empty change set is handled, then verify that repeated no-change deployments no longer leave failed change sets behind and do not hit the stack change-set limit.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, python
Domain
cli, cloud
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.