aws / aws/aws-cdk

More specific scaffoled gitignore regarding *.js

Open
#6,626 5 comments 2 reactions 0 assignees View on GitHub
effort/small feature-request p2 package/tools
Dominant language
TypeScript
Stars
12.9k
Forks
4.6k
Avg merge
2d 3h
Merged PRs (30d)
83

Description

atm the default .gitignore has the line `*.js`, this leads to problems, when you have cdk in the root folder of your project and any javascript project in a subfolder.

Personally I had a vuejs project in a subfolder, which failed to build in CI, because files were missing because of the CDK gitignore

### Proposed Solution

switch scaffolded .gitignore to
```
bin/*.js
lib/*.js
```

* [ ] :wave: I may be able to implement this feature request
* [ ] :warning: This feature might incur a breaking change

---

This is a :rocket: Feature Request

Contributor guide

Open the contributing guide

Research direction

Locate the scaffolded .gitignore template responsible for the default `*.js` entry and inspect how CDK projects are generated. Verify the generated file uses `bin/*.js` and `lib/*.js`, while JavaScript files in nested projects remain available to CI.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, git, typescript
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.