aws-rds: Support manageMasterUserPassword for DatabaseInstanceFromSnapshot
- Dominant language
- TypeScript
- Stars
- 12.9k
- Forks
- 4.6k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 83
Description
### Describe the feature
Add `manageMasterUserPassword` support to `DatabaseInstanceFromSnapshotProps`.
### Use Case
`DatabaseInstance` and `DatabaseClusterFromSnapshot` already support `manageMasterUserPassword` (added in #35734), but `DatabaseInstanceFromSnapshot` does not. Per the [`RestoreDBInstanceFromDBSnapshot` API docs](https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_RestoreDBInstanceFromDBSnapshot.html), this applies to RDS for Oracle only.
An Oracle user restoring an instance from a snapshot currently has to use the L1 escape hatch:
```ts
(instance.node.defaultChild as rds.CfnDBInstance).addPropertyOverride('ManageMasterUserPassword', true);
```
### Proposed Solution
Add `manageMasterUserPassword` to `DatabaseInstanceFromSnapshotProps` with a synth-time validation that rejects non-Oracle engines.
### Other information
- Related PR: #35734
### Acknowledgements
- [ ] I may be able to implement this feature request
- [ ] This feature might incur a breaking change
Contributor guide
Research direction
Start by comparing the existing manageMasterUserPassword support in DatabaseInstance and DatabaseClusterFromSnapshot, using related PR #35734 as context. Add the option to DatabaseInstanceFromSnapshotProps with synth-time validation based on the Oracle-only API behavior; done means Oracle restores accept it and non-Oracle engines are rejected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, typescript
- Domain
- cloud
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100