aws / aws/aws-cdk

(triggers): custom resource driving a Trigger should be configurable to be placed in VPC

Open
#35,768 2 comments 0 reactions 0 assignees View on GitHub
@aws-cdk/triggers effort/small feature-request p3
Dominant language
TypeScript
Stars
12.9k
Forks
4.6k
Avg merge
2d 3h
Merged PRs (30d)
83

Description

### Describe the feature

Expose the ability to set the VPC for the lambda driving the CustomResource inside a Trigger or TriggerFunction.

### Use Case

This lack was exposed inspecting our lambdas and finding which ones were not in a VPC. Anything that came from a Trigger (or TriggerFunction) had the underlying lambda outside the VPC. We seek to have all our lambdas inside our VPC.

### Proposed Solution

_No response_

### Other Information

Relevant code:
https://github.com/aws/aws-cdk/blob/v2.220.0/packages/aws-cdk-lib/triggers/lib/trigger.ts#L125-L134

Relevant issues:
https://github.com/aws/aws-cdk/issues/22456
https://github.com/aws/aws-cdk/issues/22473

### Acknowledgements

- [ ] I may be able to implement this feature request
- [ ] This feature might incur a breaking change

### AWS CDK Library version (aws-cdk-lib)

2.199.0

### AWS CDK CLI version

2.1017.0

### Environment details (OS name and version, etc.)

Ubuntu 20.04.4 LTS

Contributor guide

Open the contributing guide

Research direction

Read packages/aws-cdk-lib/triggers/lib/trigger.ts around lines 125-134, then trace how Trigger and TriggerFunction create the custom resource's Lambda. Review related issues #22456 and #22473 for context. Done means callers can configure the Lambda's VPC and the generated Lambda is placed in that VPC.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, typescript
Domain
cloud, infrastructure
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.