aws / aws/aws-cdk

lambda: EventSourceMapping in 2.159.0 introduced Tags, which are not supported in cn-north-1

Open
#31,532 14 comments 0 reactions 0 assignees View on GitHub
@aws-cdk/aws-lambda bug effort/medium needs-cfn p2
Dominant language
TypeScript
Stars
12.9k
Forks
4.6k
Avg merge
2d 3h
Merged PRs (30d)
83

Description

### Describe the bug

Hi Team,
after updating to 2.159.0 or 2.159.1 our deployment in cn-north-1 fails because of the error:
Resource handler returned message: "Model validation failed (#: extraneous key [Tags] is not permitted)"

The error message already says it, but we compared the old template of 2.158.0 with the template of 2.159.1 and we noticed that Tags were added to EventSourceMapping. We do not explicitly set those tags, but it seems that cdk does that for us.

In theory this is nice, but this creates an issue in cn-north-1. It seems that there the EventSourceMappings do not support Tags yet.

### Regression Issue

- [ ] Select this option if this issue appears to be a regression.

### Last Known Working CDK Version

_No response_

### Expected Behavior

Only compatible changes with all AWS partition and regions are applied. So I guess:
Option 1: wait with adding Tag support until Tags for EventSourceMapping is supported in all partitions and regions
Option 2: Include a more complex solution, which exclude Tags in China partition until it is also supported there.

### Current Behavior

The deployment fails in cn-north-1

### Reproduction Steps

Create a lambda with SQS EventSource and try to roll it out in China.

### Possible Solution

See expected behavior section

### Additional Information/Context

_No response_

### CDK CLI Version

2.159.1

### Framework Version

_No response_

### Node.js Version

20.17

### OS

Ubuntu

### Language

Java

### Language Version

_No response_

### Other information

_No response_

Contributor guide

Open the contributing guide

Research direction

Start at the Lambda EventSourceMapping implementation and the generated template for an SQS event source; compare versions 2.158.0 and 2.159.1 to find where Tags are added. Reproduce the deployment in cn-north-1, then verify that the resulting template avoids unsupported Tags there while preserving tagging support where it is available.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, typescript
Domain
cloud, infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.