aws / aws/aws-cdk

aws-s3: SkipDestinationValidation should not have default value when not used. It triggers CR's accidentally

Open
#31,230 13 comments 7 reactions 0 assignees View on GitHub
@aws-cdk/aws-s3 bug effort/small p2
Dominant language
TypeScript
Stars
12.9k
Forks
4.6k
Avg merge
1d 19h
Merged PRs (30d)
74

Description

### Describe the bug

https://github.com/aws/aws-cdk/issues/30914 introduced default value that is set always to false. The wanted behaviour would be that it would be omit when not defined.

Similar issue like this which was rollback: https://github.com/aws/aws-cdk/issues/30121

### Regression Issue

- [ ] Select this option if this issue appears to be a regression.

### Last Known Working CDK Version

2.154.1

### Expected Behavior

No default value. Default value triggers all custom resources.

### Current Behavior

Added new default value -> triggers CRs

### Reproduction Steps

Update CDK, CRs are triggered which causes problems in many CR definitions in generally (not designed for re-run).

### Possible Solution

_No response_

### Additional Information/Context

_No response_

### CDK CLI Version

2.154.1

### Framework Version

_No response_

### Node.js Version

latest

### OS

any

### Language

TypeScript

### Language Version

_No response_

### Other information

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by reviewing issue 30914 and the rollback issue 30121, then reproduce the behavior on the affected CDK versions using an aws-s3 custom resource. Done means SkipDestinationValidation is omitted when not defined and updating CDK no longer triggers those custom resources unexpectedly.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, typescript
Domain
cloud, infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.