secretsmanager: allow to specify semanticVersion in semanticVersionForPartition
- Dominant language
- TypeScript
- Stars
- 12.9k
- Forks
- 4.6k
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 83
Description
### Describe the bug
`semanticVersionForPartition` has pinned version which does not allow users to specify the version number.
At this moment, `1.1.212` for aws-cn comes with deprecated python runtime and there's no workaroud for that.
https://github.com/aws/aws-cdk/blob/4b6dc8c650822bcd0231c8890bd94a934a0cd34d/packages/aws-cdk-lib/aws-secretsmanager/lib/secret-rotation.ts#L161-L172
### Expected Behavior
We should allow user to specify the version number.
### Current Behavior
User can't specify version number and requires a PR to bump the version.
### Reproduction Steps
similar to https://github.com/aws/aws-cdk/issues/28696
### Possible Solution
### Additional Information/Context
_No response_
### CDK CLI Version
v2.141.0
### Framework Version
_No response_
### Node.js Version
all
### OS
all
### Language
TypeScript
### Language Version
_No response_
### Other information
_No response_
Contributor guide
Research direction
Start in packages/aws-cdk-lib/aws-secretsmanager/lib/secret-rotation.ts at the semanticVersionForPartition implementation referenced by the issue. Trace how the pinned version is selected and check the surrounding Secrets Manager rotation API. Done means users can specify the version number instead of requiring a library change to bump it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, typescript
- Domain
- cloud, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100