aws / aws/aws-cdk

rds: CfnDBProxy is not taggable

Open
#28,107 1 comment 1 reaction 0 assignees View on GitHub
@aws-cdk/aws-rds bug effort/medium p2
Dominant language
TypeScript
Stars
12.9k
Forks
4.6k
Avg merge
2d 3h
Merged PRs (30d)
83

Description

### Describe the bug

rds.CfnDBProxy.tags is currently type `TagFormatProperty[]` which would not be considered as taggable based on [this logic](https://github.com/aws/aws-cdk/blob/ee85afb1429c2859bab3f0f6310dfbf37d323210/packages/aws-cdk-lib/core/lib/tag-aspect.ts#L74-L80).

image

I guess this is incorrectly typed.

### Expected Behavior

CfnDBProxy should be a taggable resource with correct type.

### Current Behavior

CfnDBProxy can't be tagged.

### Reproduction Steps

`Tags.of(proxy).add('foo','bar');`

and the L1 proxy resource will not be tagged.

### Possible Solution

correct the type of the CfnDBProxy resource.

### Additional Information/Context

_No response_

### CDK CLI Version

2.110.0

### Framework Version

_No response_

### Node.js Version

v18.16.0

### OS

mac os x

### Language

TypeScript

### Language Version

_No response_

### Other information

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with the taggability logic in packages/aws-cdk-lib/core/lib/tag-aspect.ts, then locate the CfnDBProxy tags declaration and compare its type with what that logic accepts. Reproduce the issue with Tags.of(proxy).add('foo','bar'); and confirm that CfnDBProxy is recognized as taggable with the corrected type.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, typescript
Domain
cloud, infrastructure
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.