aws / aws/aws-cdk

(aws-wafv2): Some structs naming pattern changed from Foo to FooAction

Open
#24,668 0 comments 0 reactions 1 assignee Claimed by @vinayak-kukreja View on GitHub
@aws-cdk/aws-wafv2 bug effort/medium p2
Dominant language
TypeScript
Stars
12.9k
Forks
4.6k
Avg merge
2d 3h
Merged PRs (30d)
83

Description

### Describe the bug

`aws_wafv2.CfnRuleGroup` struct names were changed from `Foo to FooAction` recently. I see the name change in,
* [AllowAction](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_wafv2.CfnRuleGroup.AllowActionProperty.html)
* [BlockAction](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_wafv2.CfnRuleGroup.BlockActionProperty.html)
* [CaptchaAction](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_wafv2.CfnRuleGroup.CaptchaActionProperty.html)
* [ChallengeAction](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_wafv2.CfnRuleGroup.ChallengeActionProperty.html)
* [CountAction](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_wafv2.CfnRuleGroup.CountActionProperty.html)

Looks like these were released in this [PR](https://github.com/aws/aws-cdk/pull/23984).

### Expected Behavior

These structs should instead just be without the `Action` suffix.

### Current Behavior

These structs are currently with the `Action` suffix.

### Reproduction Steps

You can see these name changes if you upgrade CDK V1 to either: [v1.192.0](https://github.com/aws/aws-cdk/releases/tag/v1.192.0) or CDK V2 to [v2.63.0](https://github.com/aws/aws-cdk/releases/tag/v2.63.0).

### Possible Solution

_No response_

### Additional Information/Context

_No response_

### CDK CLI Version

2.69.0 (build 60a5b2a)

### Framework Version

_No response_

### Node.js Version

v14.19.3

### OS

Mac OS

### Language

Typescript

### Language Version

_No response_

### Other information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.