aws / aws/aws-cdk

(aws-codepipeline-actions:ecr): (add registryId to EcrSourceActionProps as a filter in eventpattern)

Open
#21,343 1 comment 0 reactions 0 assignees View on GitHub
@aws-cdk/triggers effort/small feature-request p2
Dominant language
TypeScript
Stars
12.9k
Forks
4.6k
Avg merge
2d 3h
Merged PRs (30d)
83

Description

### Describe the feature

As an Engineer, I want registryId added into the EcrSourceActionProps interface similar to imageTag.
The registryId will be used in onCloudTrailImagePushed as well such that the rule will filter putImage event not match the registryId.

>

### Use Case

I have a usecase which use ecr as source, and eventually putImage to another account.
However, this codepipeline enters loop since the rule to trigger the pipeline doesn't filter the registryID. so the event of putImage to another account will trigger a new pipeline in current account.

### Proposed Solution

add registryId as an optional argument similar to imageTag

### Other Information

_No response_

### Acknowledgements

- [X] I may be able to implement this feature request
- [ ] This feature might incur a breaking change

### CDK version used

2.0.0

### Environment details (OS name and version, etc.)

MacOS Monterey 12.3.1

Contributor guide

Open the contributing guide

Research direction

Start by locating the EcrSourceActionProps interface and the onCloudTrailImagePushed implementation. Check the related tests for imageTag behavior and add coverage for registryId filtering. Done means registryId is optional and putImage events for another registry do not trigger the pipeline.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, typescript
Domain
cloud, devops
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.