aws / aws/aws-cdk

ECS: Memory reservation is not optional

Open
#20,785 9 comments 1 reaction 0 assignees View on GitHub
@aws-cdk/aws-ecs bug effort/small p2
Dominant language
TypeScript
Stars
12.9k
Forks
4.6k
Avg merge
1d 19h
Merged PRs (30d)
74

Description

### Describe the bug

task memory config is required in CDK but not supported by windows instances

https://github.com/aws/aws-cdk/blob/ddb4766785e27fbd4d672a5ff31fb07c3d3d389a/packages/%40aws-cdk/aws-ecs/lib/base/task-definition.ts#L682-L695

### Expected Behavior

should allow it to be undefined

### Current Behavior

throws exception

### Reproduction Steps

leave out memory keys

### Possible Solution

_No response_

### Additional Information/Context

_No response_

### CDK CLI Version

latest

### Framework Version

_No response_

### Node.js Version

16

### OS

mac

### Language

Typescript

### Language Version

_No response_

### Other information

_No response_

Contributor guide

Open the contributing guide

Research direction

Inspect packages/@aws-cdk/aws-ecs/lib/base/task-definition.ts at lines 682-695, then reproduce the exception by leaving out the memory keys. Done means the task memory configuration can be undefined for Windows instances without throwing an exception.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, typescript
Domain
cloud, infrastructure
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.