(secretsmanager): implementation of non-deprecated API uses deprecated API
- Dominant language
- TypeScript
- Stars
- 12.9k
- Forks
- 4.6k
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 74
Description
Here's the flow -
`AttachedSecretOptions` is deprecated but its sub-interface `SecretAttachmentTargetProps` is not - https://github.com/aws/aws-cdk/blob/d9f7b58a91a625ffd9bc366767794a3101b0afeb/packages/%40aws-cdk/aws-secretsmanager/lib/secret.ts#L608-L610.
The deprecation note points to use `secret.attach()` which uses `SecretAttachmentTargetProps`, hence using `AttachSecretOptions` again.
Contributor guide
Research direction
Start in packages/@aws-cdk/aws-secretsmanager/lib/secret.ts around the AttachedSecretOptions and SecretAttachmentTargetProps definitions. Trace secret.attach() and the implementation that uses AttachSecretOptions, then check the related tests or type checks. Done means the non-deprecated API no longer depends on the deprecated API and the existing behavior remains covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, typescript
- Domain
- cloud, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100