aws / aws/aws-cdk

(pipelines): Adding a ManualApprovalStep to a Wave

Open
#16,130 15 comments 1 reaction 0 assignees View on GitHub
@aws-cdk/pipelines bug effort/medium p2
Dominant language
TypeScript
Stars
12.9k
Forks
4.6k
Avg merge
2d 3h
Merged PRs (30d)
83

Description

It seems that the following code does not really add the `ManualApprovalStep` before the build action. What would be the proper way to do this with the new CDK Pipelines?

```ts
pipeline.addWave('CustomWave', {
pre: [new pipelines.ManualApprovalStep('ManualApproval')],
post: [
new pipelines.CodeBuildStep('CustomWaveAction', {
projectName: 'CustomWaveActionBuild',
commands: [
// add rest of the commands here..
],
})],
});

```

### Environment

- **CDK CLI Version :** 2.0.0-rc.17 (build fb5dc58)
- **Framework Version:** 2.0.0-rc.17 (build fb5dc58)
- **Node.js Version:** 14
- **OS :** macOS
- **Language (Version):** all

### Other

---

This is :bug: Bug Report

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the `pipeline.addWave` example with `ManualApprovalStep` in `pre` and `CodeBuildStep` in `post`, using the reported CDK Pipelines versions. Trace how `addWave`, `pre`, and `post` are translated into pipeline stages; done means the manual approval gates the build action as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, typescript
Domain
ci-cd, cloud
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.