aws / aws/aws-cdk

(aws-cdk): Please consider picomatch or micromatch over minimatch

Open
#13,825 15 comments 0 reactions 0 assignees View on GitHub
effort/small feature-request feature/enhancement p3 package/tools
Dominant language
TypeScript
Stars
12.9k
Forks
4.6k
Avg merge
2d 3h
Merged PRs (30d)
83

Description

## :question: General Issue

### The Question

In delving into the different ways I can use globs to signal which services to act upon with the CLI, I discovered that the aws-cdk is [making use of `minimatch`](https://github.com/aws/aws-cdk/blob/6f6e079569fcdb7e0631717fbe269e94f8f7b127/packages/aws-cdk/lib/api/cxapp/cloud-assembly.ts#L108). Astute choice, but not the most optimal IMHO. Both `picomatch` and `micromatch` have enjoyed more recent updates and share a wider feature set. Negating is still particularly troublesome with `minimatch`. Couple that with both alternative having the backing of most of the ecosystem's major toolsets these days, and I'm left very curious about the choice of using `minimatch`.

Would the project consider using one of the alternatives for a better end-user experience?

### Environment

- **CDK CLI Version:** 1.95.1
- **Module Version:** 1.95.1
- **Node.js Version:** 14.5.3
- **OS:** MacOS
- **Language (Version):** TS

### Other information

Contributor guide

Open the contributing guide

Research direction

Start by inspecting packages/aws-cdk/lib/api/cxapp/cloud-assembly.ts at the linked minimatch use and the surrounding CLI glob handling. Compare the requested picomatch and micromatch behavior, especially negation, and define a tested compatibility criterion before deciding whether a dependency change is warranted.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, typescript
Domain
cli, tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.