aws / aws/aws-cdk-cli

(integ-runner): `integ-runner` ignores stack list arg for destroy

Open
#783 0 comments 0 reactions 0 assignees View on GitHub
bug p2
Dominant language
TypeScript
Stars
105
Forks
122
Avg merge
1d 17h
Merged PRs (30d)
71

Description

Today, someone can write this:
```
integ = new IntegTest(appContext.cdkApp, `IntegTest`, {
testCases: [stack, otherStack],
assertionStack: testStack,
enableLookups: true,
stackUpdateWorkflow: false,
cdkCommandOptions: {
destroy: {
stacks: [otherStack.node.id], // this is ignored
},
},
});
```
However the `stacks` argument get's ignored as the implementation is always forcing `--all` on the run.

We should either:
- fix the bug
- document the inconsistency (not preferred), or
- remove the option completely.

---

Haven't thought about this a lot, but from an `integ-runner` product perspective I don't like these options. It makes the tool to generic. If this specificity is needed, someone can just use the Toolkit (CLI or library) directly. So I'm inclined to remove support for most options and only keep some that make sense.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.