aws / aws/aws-cdk-cli

(diff): --change-set flag not configurable via cdk.json

Open
#755 4 comments 2 reactions 0 assignees View on GitHub
effort/medium feature-request p2
Dominant language
TypeScript
Stars
105
Forks
122
Avg merge
1d 17h
Merged PRs (30d)
71

Description

### Describe the bug

A new flag was introduced as part of aws/aws-cdk#28336

This flag doesn't seem to be set to wanted default value using the cdk.json.

There's also missing documentation about this flag in the [CLI reference](https://docs.aws.amazon.com/cdk/v2/guide/cli.html). Arguably a different issue since it'll be a different repo? I'm not sure how to report that. Feel free to point me in the right direction.

### Expected Behavior

Ability to override default value in `cdk.json`

### Current Behavior

Anything set in in the `cdk.json` will be ignored

### Reproduction Steps

1. Use any stack setup
2. Run a diff
3. You'll see the following output on the stack:

```
Hold on while we create a read-only change set to get a diff with accurate replacement information (use --no-change-set to use a less accurate but faster template-only diff)
```

4. Try to override the `change-set` flag in `cdk.json` to false
5. Run diff again

expected: warning message above dissapears
actual: still seeing the warning (behaviour hasn't changed)

### Possible Solution

_No response_

### Additional Information/Context

_No response_

### CDK CLI Version

2.128.0

### Framework Version

_No response_

### Node.js Version

v20.11.1

### OS

darwin ARM64

### Language

TypeScript

### Language Version

_No response_

### Other information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.