aws / aws/aperf

APerf hotline interface has missing/wrong data

Open
#442 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Rust
Stars
222
Forks
40
Avg merge
1m
Merged PRs (30d)
7

Description

I am experimenting with the hotline feature on C7g.metal and I am seeing places where data is missing or wrong.

In the completion node view attached here is an example of missing data, I have a line identified as being sourced from DRAM 25% of the time, but I have no sample count or indication if its important or not. Was this seen 10 times? 1000 times?
Image

In the branch view I see that branches on C7g.metal were all labeled as "Indirect" when the tagged assembly code are conditional direct, or unconditional direct branches instead which is wrong. It needs to be double-checked if hotline is assuming a particular version of SPE and make sure there are no differences between different implementations where it might be extracting the wrong bitfields to cause this.

Lastly, the location/source line/function/assembly can resolve to all `(null)` for some binaries which makes the information useless because some key information is missing. Aperf needs to also include the binary path it is trying to extract information to indicate to the user which binary is missing symbols and provide a helper tip on how to get symbols for use with hotline.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the hotline completion-node and branch views on C7g.metal, then inspect the SPE assumptions, branch bitfield handling, and symbol-resolution behavior described here. Done means sample counts and importance are shown, branch types are correct, and unresolved data identifies the binary path with a symbol-retrieval hint.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, rust
Domain
cli, observability, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.