aws / aws/amazon-vpc-resource-controller-k8s

Vlan ID should be released after branch ENI is disassociated from trunk ENI

Open
#595 0 comments 0 reactions 1 assignee Claimed by @yash97 View on GitHub
enhancement good first issue
Dominant language
Go
Stars
106
Forks
71
Avg merge
10h 28m
Merged PRs (30d)
6

Description

**What would you like to be enhanced**:
Currently the vlan ID release is depending on a successful deleting branch ENI from the trunk ENI by EC2 API call. If for any reason, the call fails, vlan ID is leaked after pods are deleted. Leaked vlan IDs occupy quotas in the node which will be unable to support the number of pods which the node is expected to do.

**Why is the change needed and what use case will it solve**:
There is no hard dependency on EC2 delete branch ENI call's success after a pod is deleted. Successful disassociation calls should be good enough to release vlan IDs for next available pods. Delete calls will be retried and the worst case that the ENIs can be cleaned by cleanup process.
https://github.com/aws/amazon-vpc-resource-controller-k8s/blob/master/pkg/provider/branch/trunk/trunk.go#L564-L593

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.