aws / aws/amazon-vpc-resource-controller-k8s

Rename Windows warm/minimum IP targets

Open
#370 1 comment 0 reactions 1 assignee Claimed by @haouc View on GitHub
enhancement
Dominant language
Go
Stars
106
Forks
71
Avg merge
10h 28m
Merged PRs (30d)
6

Description

**What would you like to be enhanced**:
I would like to rename the Windows warm/minimum IP target variables that are read from the `amazon-vpc-cni` ConfigMap: https://github.com/aws/amazon-vpc-resource-controller-k8s/blob/master/pkg/config/type.go#L76

The current names cause confusion with the environment variables in the `aws-node` Daemonset that are used for warm/minimum targets on Linux nodes. I propose that we rename these to `windows-*`.

Since we cannot do the switchover all at once, I propose the VPC Resource Controller starts accepting both names, which will allow the AWS VPC CNI chart to change its names to the `windows-*` values.

**Why is the change needed and what use case will it solve**:
This change would help avoid customer confusion when it comes to deploying the AWS VPC CNI chart.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.