aws / aws/amazon-ssm-agent

Vendored copy of AWS SDK drifted from forked copy and breaks the build

Closed
#675 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
1.2k
Forks
357
PR merge metrics
No merged PRs in 30d

Description

In the latest release of Amazon SSM Agent, the vendored copy of the AWS SDK in `vendor/` was edited as part of commit https://github.com/aws/amazon-ssm-agent/commit/7425d49001b8fd8089f964bcd2c8a229c1b150a3. The actual fork of the SDK in `extra/`, and referenced in the `replace` directive in `go.mod`, was left untouched. As a result, on `go mod vendor`, the vendored copy loses the bits needed to build the latest release.

Please update the fork of the SDK in `extra/` so that a build succeeds after `go mod vendor`. You may also want to consider a CI check that ensures both copies stay in sync, i.e. a `go mod vendor` produces an empty `git diff`.

Longer term, are there plans to migrate to v2 of the AWS SDK?

Contributor guide

Open the contributing guide

Research direction

Start by reading go.mod and comparing the forked SDK under extra/ with the vendored copy under vendor/. Run go mod vendor, inspect the resulting git diff, and then run the project build to confirm the dependency remains intact. Done means the build succeeds and go mod vendor produces an empty diff; the optional CI check would enforce that condition.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, go
Domain
build-system, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.