aws / aws/amazon-ssm-agent

Tools/src/checkstyle.sh refers to non-existent Tools/bin/goimports

Open
#596 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
1.2k
Forks
357
PR merge metrics
No merged PRs in 30d

Description

This causes these error messages to be output during the build:

```
/Users/mark.sheppard/code/amazon-ssm-agent/Tools/src/checkstyle.sh: line 37: Tools/bin/goimports: No such file or directory
/Users/mark.sheppard/code/amazon-ssm-agent/Tools/src/checkstyle.sh: line 47: Tools/bin/goimports: No such file or directory
/Users/mark.sheppard/code/amazon-ssm-agent/Tools/src/checkstyle.sh: line 57: Tools/bin/goimports: No such file or directory
```

Fixing that by changing `Tools/bin/goimports` to be just `goimports` then causes the build to fail:

```
Error: Found files not formatted by goimports
/Users/mark.sheppard/code/amazon-ssm-agent/agent/fileutil/artifact/artifact_integ_test.go
/Users/mark.sheppard/code/amazon-ssm-agent/agent/plugins/dockercontainer/dockercontainer_test.go
/Users/mark.sheppard/code/amazon-ssm-agent/agent/plugins/domainjoin/domainjoin_common.go
/Users/mark.sheppard/code/amazon-ssm-agent/agent/ssm/authtokenrequest/authtokenrequest_client.go
/Users/mark.sheppard/code/amazon-ssm-agent/agent/ssm/util/util_test.go
/Users/mark.sheppard/code/amazon-ssm-agent/agent/update/processor/processor.go
Please run 'goimports -w' for files listed.
make: *** [makefile:21: checkstyle] Error 1
```

Contributor guide

Open the contributing guide

Research direction

Read Tools/src/checkstyle.sh at lines 37, 47, and 57, then inspect the listed Go files reported by the checkstyle run. Run the checkstyle build target to reproduce the missing goimports errors and formatting failures; done means the command resolves correctly and the checkstyle target passes without those messages.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, shell
Domain
build-system, tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.