aws / aws/amazon-sagemaker-examples

[Bug Report] Example notebook has incorrectly formatted serving.properties

Open
#4,595 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
11k
Forks
7k
Avg merge
8h 29m
Merged PRs (30d)
8

Description

**Link to the notebook**
[Add the link to the notebook.](https://github.com/aws/amazon-sagemaker-examples/blob/main/inference/generativeai/llm-workshop/deploy-V7-lmi/llama2_70b-lmi-trtllm.ipynb)

**Describe the bug**
The example serving.properties written by this notebook is using spaces before and after the equals sign, which makes DJL ignore those values. E.g. key = value (incorrect) vs. key=value (correct).

**To reproduce**
N/A, see above

**Logs**
N/A, see above.

Contributor guide

Open the contributing guide

Research direction

Open inference/generativeai/llm-workshop/deploy-V7-lmi/llama2_70b-lmi-trtllm.ipynb and locate the cell that writes serving.properties. Check the generated property formatting, then update it so assignments have no spaces around the equals sign and verify the notebook produces DJL-readable values.

Written by the indexing model from the issue text.

Assessment

Tech stack
jupyter-notebook
Domain
machine-learning
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.