aws / aws/amazon-sagemaker-examples
[Bug Report]
- Dominant language
- Jupyter Notebook
- Stars
- 11k
- Forks
- 7k
- Avg merge
- 8h 29m
- Merged PRs (30d)
- 8
Description
**Link to the notebook**
https://github.com/aws/amazon-sagemaker-examples/blob/main/advanced_functionality/tensorflow_bring_your_own/tensorflow_bring_your_own.ipynb
**Describe the bug**
get-login is deprecated
`$(aws ecr get-login --region ${region} --no-include-email)`
**Solution**
Replace line with
`aws ecr get-login-password | docker login -u AWS --password-stdin "https://$(aws sts get-caller-identity --query 'Account' --output text).dkr.ecr.${region}.amazonaws.com"`
**To reproduce**
just running the second cell gets the bug
Contributor guide
Research direction
Open advanced_functionality/tensorflow_bring_your_own/tensorflow_bring_your_own.ipynb and inspect the second cell, where the deprecated ECR login command is used. Run the cell to reproduce the failure, update that command as described in the issue, and rerun it to confirm the notebook proceeds without the get-login error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, docker, jupyter-notebook
- Domain
- cloud, devops
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100