aws / aws/amazon-q-developer-cli

Suggestion: reading files should not operate under execute_bash

Open
#3,483 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
2k
Forks
439
PR merge metrics
No merged PRs in 30d

Description

execute_bash is very wide, it could be changing files with that command, so I don't really want to give it blanket trust to do that most of the time. But reading files is idempotent and non-destructive so it makes sense to trust that operation (`t` instead of `y`).

I'm asking Q to search through a codebase and sometimes it's using fs_read and sometimes it's using execute_bash, so maybe that's the deeper issue.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.