aws / aws/amazon-q-developer-cli

[Feature Request / UX Issue] DarkGrey color used in confirmation dialogs is not visible on Solarized dark Terminal theme

Open
#2,295 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Rust
Stars
2k
Forks
439
PR merge metrics
No merged PRs in 30d

Description

When using Solarized Dark theme in iTerm2, the text printed used DarkGrey colour which primarily used for confirmation dialogs is not visible. DarkGrey color has low visibility in dark themes, and this issue will also impact other popular low contrast themes. The text is only visible when you select the region in the terminal. Please see the screenshot below.

Image

After selecting the region in the terminal.
Image

This particular issue is caused by the use of DarkGrey colours on line 1184 - 1205 of src/cli/chat/mod.rs file, through DarkGrey color is extensively used in other places.

``` Rust
if show_tool_use_confirmation_dialog {
execute!(
self.stderr,
style::SetForegroundColor(Color::DarkGrey),
style::Print("\nAllow this action? Use '"),
style::SetForegroundColor(Color::Green),
style::Print("t"),
style::SetForegroundColor(Color::DarkGrey),
style::Print("' to trust (always allow) this tool for the session. ["),
style::SetForegroundColor(Color::Green),
style::Print("y"),
style::SetForegroundColor(Color::DarkGrey),
style::Print("/"),
style::SetForegroundColor(Color::Green),
style::Print("n"),
style::SetForegroundColor(Color::DarkGrey),
style::Print("/"),
style::SetForegroundColor(Color::Green),
style::Print("t"),
style::SetForegroundColor(Color::DarkGrey),
style::Print("]:\n\n"),
style::SetForegroundColor(Color::Reset),
)?;
}
```

One possible option would be to use the default colour for the text, except for "[y/n/t]" within confirmation dialogs. Happy to discuss options as well.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.