aws / aws/amazon-q-developer-cli

bug: (short issue descriptionDuplicate ~/.local/bin in PATH due to incorrect path existence check in Amazon Q shell scripts)

Open
#2,013 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
2k
Forks
439
PR merge metrics
No merged PRs in 30d

Description

### Checks

- [x] I have searched [github.com/aws/amazon-q-developer-cli/issues](https://github.com/aws/amazon-q-developer-cli/issues?q=) and there are no duplicates of my issue

### Operating system

Linux (Ubuntu/Debian-based distribution)

### Expected behaviour

Describe the bug
Amazon Q shell scripts (profile.pre.bash and profile.post.bash) incorrectly check for the existence of ~/.local/bin in the PATH
variable, which leads to this path being added twice to the PATH. The current check [[ ":$PATH:" != ":$_Q_LOCAL_BIN:" ]] doesn't
properly detect if the path is already present.

Regression Issue

Select this option if this issue appears to be a regression.
Expected Behavior
The PATH variable should contain ~/.local/bin only once. The check in Amazon Q shell scripts should correctly detect if the path is
already present in PATH and not add it again.

### Actual behaviour

Current Behavior
The PATH variable contains ~/.local/bin twice:
/home/user/.local/bin:/other/paths:/home/user/.local/bin

This happens because:

~/.profile adds ~/.local/bin to PATH
Amazon Q shell scripts (profile.pre.bash and profile.post.bash) add it again due to incorrect path existence check

### Steps to reproduce

Reproduction Steps
Have ~/.local/bin added to PATH in ~/.profile (standard in many Linux distributions)
Install Amazon Q CLI
Check PATH variable with echo $PATH
Observe that ~/.local/bin appears twice in the PATH
Possible Solution
Replace the current check in both profile.pre.bash and profile.post.bash:

From:
bash
[[ ":$PATH:" != ":$_Q_LOCAL_BIN:" ]] && PATH="${PATH:+"$PATH:"}$_Q_LOCAL_BIN"

To a more accurate check using regex:
bash
if [[ ! "$PATH" =~ (^|:)"$_Q_LOCAL_BIN"(:|$) ]]; then
PATH="${PATH:+"$PATH:"}$_Q_LOCAL_BIN"
fi

This regex properly checks if the path exists as a complete segment in the PATH variable.

Additional Information/Context
This issue doesn't cause functional problems but is a minor inefficiency as the shell has to search the same directory twice when
looking for executables.

CLI version used
Amazon Q CLI (latest version)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.