aws / aws/amazon-eks-pod-identity-webhook

Allow/document configuration via env vars

Open
#65 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
691
Forks
202
Avg merge
4h 38m
Merged PRs (30d)
1

Description

Currently it seems to be required that configuration is done with command line arguments (e.g. `--service-name=pod-identity-webhook`), it would be useful if the daemon also looked at environment variables (e.g. `AMAZON_EKS_POD_IDENTITY_WEBHOOK_SERVICE_NAME=pod-identity-webhook`)

Each command line argument should have a matching env var, which is uppercased, `-` swapped for `_`, and prefixed with e.g. `AMAZON_EKS_POD_IDENTITY_WEBHOOK_`.

Contributor guide

Open the contributing guide

Research direction

Start by locating the daemon's command-line argument definitions and configuration initialization. Check how each argument is parsed, then verify that every argument has the specified prefixed environment-variable equivalent and that configuration from both sources is covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.