aws / aws/amazon-eks-pod-identity-webhook

Add eks.amazonaws.com/include-containers annotation

Open
#147 2 comments 2 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
691
Forks
202
Avg merge
4h 38m
Merged PRs (30d)
1

Description

**What would you like to be added**:

Add support for a `eks.amazonaws.com/include-containers`. It is a comma-separated list of container names into which the token and env vars will be injected. Other containers will not be modified. If specified, then `eks.amazonaws.com/skip-containers` is ignored.

**Why is this needed**:

Building up a negative list for `eks.amazonaws.com/skip-containers` is cumbersome, as we have to account for all sidecars being injected by other webhooks. Typically we only have one "main" container that needs the credentials, so it would be a lot simpler to just put its name.

Contributor guide

Open the contributing guide

Research direction

Locate the webhook's annotation handling and the tests covering token and environment-variable injection. Verify how eks.amazonaws.com/skip-containers is processed, then define coverage for the comma-separated eks.amazonaws.com/include-containers list, including the rule that include-containers takes precedence; done means only named containers are modified.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, go, kubernetes
Domain
cloud, devops, infrastructure
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.