aws / aws/amazon-documentdb-odbc-driver

Re-enable cppcheck

Open
#171 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
6
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Right now, since installing `cppcheck` via `chocolatey` requires a reboot (which GitHub Actions is not supporting as far as I know), it is failing on Windows 2022 x32 and x64 builds.  `choco install cppcheck -y` is returning 3010, which [GitHub actions treats as a failure](https://docs.github.com/en/enterprise-server@3.4/actions/creating-actions/setting-exit-codes-for-actions#about-exit-codes) as it is non-zero.
For more details on the failure see [here](https://github.com/Bit-Quill/amazon-documentdb-odbc-driver-mirror/runs/6580015859?check_suite_focus=true#step:3:392). Maybe we will need to use other packaging or install `cppcheck` manually.

A cppcheck GitHub Action on the market (could perhaps use this): [cppcheck-action](https://github.com/deep5050/cppcheck-action)

AC: Investigate and reactive the `cppcheck` in Windows GitHub Actions.

Contributor guide

Open the contributing guide

Research direction

Start with the Windows 2022 x32 and x64 GitHub Actions steps that install cppcheck, especially the failing `choco install cppcheck -y` command. Compare the available packaging or cppcheck-action options, then verify that cppcheck runs again and both Windows builds pass without treating exit code 3010 as a failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, github-actions
Domain
build-system, ci-cd, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.