aws / aws/amazon-cloudwatch-agent-test

Create integration test for renaming Windows system metric

Open
#253 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
22
Forks
45
Avg merge
2d 21h
Merged PRs (30d)
10

Description

The logic for deriving the default name for Windows metrics differs from Unix. Rather than using a `_` to separate, on Windows, the agent uses ` ` to separate. For example, instead of `cpu_time_active`, for the CPU plugin, the agent would hypothetically decorate the metric as `cpu time_active`. A bug was identified where we weren't properly renaming the metric when the prefix is omitted in the rename configuration, e.g.: `"rename": "time_active"` on Linux. The integration test that checks this on Linux is failing in our staging repo. There is nothing that would have caught this for Windows, as of right now. We need to add an integration test for that edge case.

Contributor guide

Open the contributing guide

Research direction

Start by locating the existing Linux integration test for renaming a metric when the prefix is omitted, then find its rename configuration and Windows-specific metric setup. Add the corresponding Windows edge-case coverage for a rename such as "time_active"; done means the test verifies the expected Windows metric name using a space separator.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability-sre, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.