aws-samples / aws-samples/samples-for-payment-cryptography-service
DataPlaneUtils.translateVisaPinBlockBdkToPek: derivation type silently discarded
- Dominant language
- Python
- Stars
- 31
- Forks
- 24
- Avg merge
- 3m
- Merged PRs (30d)
- 1
Description
DataPlaneUtils.java lines 100/117–119: the code calls dupktAttributes.toBuilder().dukptKeyDerivationType(outDukptDerivationType).build(); without reassigning — a no-op, since SDK v2 objects are immutable. So outDukptDerivationType is dropped for this direction. The sibling translateVisaPinBlockPekToBdk (line 85) does it correctly (dupktAttributes = dupktAttributes.toBuilder()…build();). Fix: reassign, mirroring the sibling.
Contributor guide
Research direction
Open DataPlaneUtils.java and inspect lines 100 and 117–119, then compare them with translateVisaPinBlockPekToBdk at line 85. Confirm the SDK v2 immutable-builder result is retained for the BDK-to-PEK direction, and verify that outDukptDerivationType is no longer dropped.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- cryptography
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 88/100