aws-samples / aws-samples/sample-autonomous-cloud-coding-agents

25 pre-existing masking findings on main fail the pre-push gate, forcing --no-verify for every contributor

Open
#766 0 comments 0 reactions 0 assignees View on GitHub
bug ci-cd tooling
Dominant language
TypeScript
Stars
143
Forks
46
Avg merge
3d 9h
Merged PRs (30d)
20

Description

## Problem

The masking-findings gate fails on **pristine `main`** with 25 pre-existing findings (up from 15 when the #763 work was briefed). Because the gate runs pre-push, every contributor must push with `--no-verify` to land anything — which also skips every *other* pre-push check, so the gate's growth is silently eroding the whole hook.

## Evidence

- Reproduced on a clean checkout of `main` (no branch changes applied): 25 findings.
- PR #763 shipped with `--no-verify` for this gate only; **no `nosemgrep` suppressions were added**, so the findings remain visible.
- The count grew 15 → 25 between the #763 brief and merge, so the backlog is actively accumulating.

## Suggested resolution

1. Triage the 25 findings on `main`: fix the real ones, suppress false positives with justified `nosemgrep` annotations.
2. Once `main` is clean, the gate becomes meaningful again and `--no-verify` stops being the default workflow.
3. Consider a baseline/ratchet mechanism (fail only on **new** findings) if a full cleanup can't land soon, so the gate blocks regressions without blocking unrelated work.

## Origin

Found during PR #763 — see the merge-guidance comment: https://github.com/aws-samples/sample-autonomous-cloud-coding-agents/pull/763#issuecomment-5289889688

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the masking-findings gate on a clean main checkout and review its 25 reported findings, using PR #763's merge-guidance comment as context. Triage each finding as real or a false positive, then verify the gate passes on clean main without --no-verify; if cleanup cannot land, assess a baseline or ratchet that blocks only new findings.

Written by the indexing model from the issue text.

Assessment

Domain
security, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.