aws-samples / aws-samples/lambda-refarch-streamprocessing

Buffer should convert to UTF8 not ASCII

Open
#2 0 comments 4 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
344
Forks
127
PR merge metrics
No merged PRs in 30d

Description

I think [line 37](https://github.com/awslabs/lambda-refarch-streamprocessing/blob/master/ddb_eventprocessor.js#L37) should be rewritten as `payload = new Buffer(record.kinesis.data, 'base64').toString('utf8');`

I recently ran into a situation where I could not for the life of me figure out why I kept getting this mysterious `unexpected token error` in Lambda's Cloudwatch console. After a few hours of testing and debugging, I finally figured out that I was passing invalid JSON Control Characters. BUT, what was really happening was I was converting chinese characters to ASCII.
The standard should be UTF8 to support our global connectivity 😉 .

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.