aws-samples / aws-samples/cdk-eks-karpenter
helmChartValues.settings overwritten
- Dominant language
- TypeScript
- Stars
- 48
- Forks
- 21
- PR merge metrics
- No merged PRs in 30d
Description
When trying to apply a feature gate value, eg; settings.featureGates.spotToSpotConsolidation, the construct currently overwrites any values because it is not doing a deep merge on objects.
https://github.com/aws-samples/cdk-eks-karpenter/blob/main/src/index.ts#L156-L162
and
https://github.com/aws-samples/cdk-eks-karpenter/blob/main/src/index.ts#L197-L199
Contributor guide
Research direction
Start in src/index.ts at lines 156-162 and 197-199, where helmChartValues.settings is assembled. Trace how the feature-gate value is applied and verify that nested existing settings are preserved rather than overwritten. Done means applying settings.featureGates.spotToSpotConsolidation retains other settings values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, kubernetes, typescript
- Domain
- cloud, devops, infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100