aws-samples / aws-samples/aws-securityhub-score-generator

Script doing incorrect score calculation and calculating scores for unenabled standards

Open
#7 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
32
Forks
15
PR merge metrics
No merged PRs in 30d

Description

My AWS environment only has one security standard enabled - AWS Foundational Security Best Practices v1.0.0
The image below verifies this.
github1

However, when I run the script, the following is the output I get -
github2

As you can see, I am getting an incorrect score for the standard that I have enabled and then further, I am getting scores for standards I have not even enabled. I know in the build_standards_dict function, you extract the control name using control.split('/')[1] and control = prodField['StandardsArn']. I am unsure how it is extracting standards that aren't even enabled.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.