aws-samples / aws-samples/aws-security-reference-architecture-examples

[BUG] sra-macie-org-main-ssm.json includes a pSRAStagingS3BucketName parameter that should be read from SSM parameters

Open
#223 0 comments 1 reaction 1 assignee Claimed by @IevIe View on GitHub
bug
Dominant language
Python
Stars
1.2k
Forks
303
Avg merge
3d 9h
Merged PRs (30d)
1

Description

**Community Note**

- Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue to help the community and maintainers prioritize this request
- Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
- If you are interested in working on this issue or have submitted a pull request, please leave a comment

### Describe the bug

When deploying Macie (via the CfCT in my case, but the same issue should happen via CloudFormation CLI), the SSM JSON parameters file (`sra-macie-org-main-ssm.json`) includes a value that should be read from it's SSM parameter and therefore not be included in the JSON file.

### To Reproduce

Steps to reproduce the behavior:

1. Copy the `sra-macie-org-main-ssm.json` file from the SRA solution to the **parameters** directory in the custom-control-tower-configuration CodeCommit repo.
2. Copy the `sra-macie-org-main-ssm.yaml` file from the SRA solution to the **templates** directory in the custom-control-tower-configuration CodeCommit repo.
3. Add an entry to the `manifest.yaml` file to deploy the solution.
4. Commit changes to kick off the pipeline
5. The Macie org solution fails to deploy with an error
```
Parameter pSRAStagingS3BucketName should either have input value or default value
```

### Expected behavior

The Macie org solution deploys without errors.

### Deployment Environment (please complete the following information)

- Deployment Framework: Customizations for Control Tower
- Deployment Framework Version: CfCT v2.7.1 and SRA examples v3.1.0

### Additional context

Removing the parameter from the JSON file allows the deployment to proceed successfully.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.