aws-samples / aws-samples/aws-security-reference-architecture-examples
[BUG] certain Security Hub standard controls should be disabled when deploying to regions other than home
- Dominant language
- Python
- Stars
- 1.2k
- Forks
- 303
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 1
Description
**Community Note**
- Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue to help the community and maintainers prioritize this request
- Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
- If you are interested in working on this issue or have submitted a pull request, please leave a comment
### Describe the bug
Per Amazon's Security Hub docs, we should disable Config.1 and some IAM controls in non-default regions:
https://docs.aws.amazon.com/securityhub/latest/userguide/config-controls.html#config-1
> To allow security checks against global resources in each Region, you also must record
> global resources. If you only record global resources in a single Region, then you can
> disable this control in all Regions except the Region where you record global resources.
When the `sra-securityhub-org` Lambda runs, it enables all controls, regardless of region.
### To Reproduce
Steps to reproduce the behavior:
Deploy the sra-securityhub-org solution through Control Tower.
### Expected behavior
Controls for Security Hub standards that are not pertinent will be disabled in non-default regions, so that controls for global resources are only tested once.
### Deployment Environment (please complete the following information)
- Customizations for Control Tower and CloudFormation StackSets
- SRA solution version 1.5
### Additional context
A proposed solution is available in [this PR against my fork of aws-security-reference-architecture-examples](https://github.com/oshaughnessy/aws-security-reference-architecture-examples/pull/2).
Contributor guide
Assessment
This issue has not been assessed yet.