aws-samples / aws-samples/aws-proton-terraform-github-actions-sample
Extra "" in --outputs "${formatted_outputs[*]}" resulting in Error parsing parameter
- Dominant language
- HCL
- Stars
- 16
- Forks
- 36
- PR merge metrics
- No merged PRs in 30d
Description
In Notify Proton Step in .github/workflows/proton_run.yml
The line 266
` aws proton notify-resource-deployment-status-change --region ${{ needs.get-deployment-data.outputs.proton_region }} --resource-arn ${{ needs.get-deployment-data.outputs.resource_arn }} --status SUCCEEDED --deployment-id ${{ needs.get-deployment-data.outputs.deployment_id }} --outputs "${formatted_outputs[*]}"`
gives error similar to:
```
Error parsing parameter '--outputs': Second instance of key "valueString" encountered for input:
key=security_group_id,valueString=sg-00bd47009c8d7f524 key=subnet_id,valueString=subnet-0dbb1eb78c0ada8b9 key=vpc_arn,valueString=arn:aws:ec2:us-east-1:127511872893:vpc/vpc-029f362a11ac62575
^
This is often because there is a preceding "," instead of a space.
```
### Solution
line 266 needs to be changed to below where --outputs "${formatted_outputs[*]}" is changed to --outputs ${formatted_outputs[*]}
` aws proton notify-resource-deployment-status-change --region ${{ needs.get-deployment-data.outputs.proton_region }} --resource-arn ${{ needs.get-deployment-data.outputs.resource_arn }} --status SUCCEEDED --deployment-id ${{ needs.get-deployment-data.outputs.deployment_id }} --outputs ${formatted_outputs[*]}`
Contributor guide
Assessment
This issue has not been assessed yet.