aws-samples / aws-samples/aws-iot-chat-example

Is `attachConfirmUserTrigger.sh` still needed?

Open
#8 1 comment 3 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
567
Forks
129
PR merge metrics
No merged PRs in 30d

Description

I recently had issues with deploying a freshly cloned version of the chat example because of the following error:
```
Error: Command failed: ./scripts/attachConfirmUserTrigger.sh
./scripts/attachConfirmUserTrigger.sh: 8: ./scripts/attachConfirmUserTrigger.sh: Syntax error: "(" unexpected
```
When I dig in a little deeper, I see the following comment at the top of the offending script:
```
# This script is used until a bug regarding Cognito User Pools in serverless is fixed
# https://github.com/serverless/serverless/pull/3799
```
When I follow that link, I see that the PR has been merged and the related issues closed. Does that mean we can remove this script (along with its corresponding detach script)?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.