aws-samples / aws-samples/aws-ct-vpc-flowlogs
"Management" is the name of account that is assumed in the manifest.yaml
- Dominant language
- Python
- Stars
- 12
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
In `manifest.yaml`, when creating the VPCFlowLogRole in Management account, it's assumed that the ControlTower Management account is named `Management`. This might not be the case.
```
- name: VPCFlowLogsMgmtRole
resource_file: vpcflowlogs/templates/vpc_flowlog_mgmt.template
parameters:
- parameter_key: "OrganizationId"
parameter_value: "$[alfred_ssm_/org/core/OrganizationID]"
- parameter_key: "EventBusDestinationAccount" # Typiclly this will be the NetworkHub account
parameter_value: "478239160000"
- parameter_key: "BaselineCloudTrailStackArn" # Copy this this from mgmt account in cloudformation stacksets for AWSControlTowerBP-BASELINE-CLOUDTRAIL
parameter_value: "arn:aws:cloudformation:eu-west-1:607614377744:stackset/AWSControlTowerBP-BASELINE-CLOUDTRAIL:f70b1254-9d9b-42b6-bedb-59a936647f6a"
deploy_method: stack_set
deployment_targets:
accounts:
- Management
regions:
- eu-west-1
```
Contributor guide
Research direction
Start in manifest.yaml at the VPCFlowLogsMgmtRole deployment target and review how the Control Tower Management account is identified. Confirm the account-name assumption and determine the repository's supported way to target that account; done means the manifest works when the Management account has a different name.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, yaml
- Domain
- cloud, infrastructure
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100