aws-samples / aws-samples/amazon-textract-textractor
TGeoFinder should have a method to reset the in memory sqlite database
- Dominant language
- Jupyter Notebook
- Stars
- 493
- Forks
- 163
- PR merge metrics
- No merged PRs in 30d
Description
Hi @Belval
1. I find out that every time when you create the [TGeoFinder](https://github.com/aws-samples/amazon-textract-textractor/blob/master/tpipelinegeofinder/textractgeofinder/tgeofinder.py#L51) class from the JSON data, you actually generate a uuid for this object and insert lot of data into the sqlite lite database. I suggest adding a optional parameter when you create TGeoFinder object, allow user to explicitly pass unique identifier as a key, so user can explicitly delete all records related to this object in database in case the original object is already garbage collected.
2. consider adding an explicit method instead of doing ``del t_geo_finder`` object for more Pythonic API.
Wonderful library!
Contributor guide
Assessment
This issue has not been assessed yet.