aws-samples / aws-samples/amazon-textract-multipage-tables-processing

Can't merge `pipeline_merge_tables` if 1st page is missing a table

Open
#1 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
6
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Was trying to get `pipeline_merge_tables` working and ended up finding a small issue. The default validation function breaks when there are no tables in the current or next page, which means that the pipeline can't scan any pages after the fact for merging.

After poking around a bit I noticed that it's because of the `break`'s here:
https://github.com/aws-samples/amazon-textract-response-parser/blob/3ba9b666a7ae8ba849003512ccb0bb8f331e35bc/src-python/trp/t_tables.py#L102
https://github.com/aws-samples/amazon-textract-response-parser/blob/3ba9b666a7ae8ba849003512ccb0bb8f331e35bc/src-python/trp/t_tables.py#L107

Opening a PR to fix this, but for now if you need a workaround just change these to `continue` locally

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.