aws-samples / aws-samples/amazon-sagemaker-multiple-object-tracking

IMAGE_NAME in set_env.sh should be changed from fairmot-sagemaker to sagemaker-fairmot

Open
#5 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
15
Forks
6
PR merge metrics
No merged PRs in 30d

Description

Hi,

There is an error in running fairmot-training.ipynb
Because AmazonSageMakerServiceCatalogProductsUseRole can create ECR repository under the resource condition that "arn:aws:ecr:*:*:repository/sagemaker-*"
So, environment value IMAGE_NAME in container-dp/build_tools/set_env.sh should follow the condition.

However, the value IMAGE_NAME is fairmot-sagemaker and it makes error.

Therefore, IMAGE_NAME in set_env.sh should be changed from fairmot-sagemaker to **sagemaker-fairmot**
Also, training_image name should be changed as follows
training_image = f"{account}.dkr.ecr.{region}.amazonaws.com/**sagemaker-fairmot**:pytorch1.8-{version_name}"

It solves the problem.
Thank you.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.