aws-samples / aws-samples/amazon-nova-samples

(S2S sample-codes/websocket-nodejs) createSessionAsyncIterable does not work with native async iterable with nodenext

Open
#117 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
452
Forks
266
PR merge metrics
No merged PRs in 30d

Description

Presently [this code](https://github.com/aws-samples/amazon-nova-samples/blob/main/speech-to-speech/sample-codes/websocket-nodejs/src/client.ts#L394-L474)

compiles down [to this](https://gist.github.com/pr1ntr/77b00891aa1c4edb04330c61f2d0193e) with the current tsconfig settings.

with my nodenext settings it compiles [like this](https://gist.github.com/pr1ntr/eb03339aaf0233bb9853256bfe125b7a)

So since newer node (Node16 for instance) supports doing this natively. When compiled to node16 or nodenext it doesn't use that generator polyfill and just hangs forever.

@prettyprettyprettygood

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.