aws-samples / aws-samples/amazon-guardduty-multiaccount-scripts

master_account type needs to be STR not INT on line 105 in disableguardduty.py

Open
#35 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
131
Forks
69
PR merge metrics
No merged PRs in 30d

Description

As an INT object, master accounts that start with a zero (0) character are flagged as invalid by the check on lines 112-114, as the account length is too short.

It seems to be correct in the enableguardduty.py script on line 121.

Contributor guide

Open the contributing guide

Research direction

Open disableguardduty.py at line 105 and compare the master_account handling with enableguardduty.py line 121; then trace the length check at lines 112-114. Done means account IDs beginning with 0 remain valid and the existing invalid-length check still behaves correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, python
Domain
cloud, security
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.