aws-samples / aws-samples/amazon-eks-custom-amis

New variables - assign public IP and target AMI name

Open
#64 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Shell
Stars
190
Forks
101
PR merge metrics
No merged PRs in 30d

Description

### Community Note

* Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue to help the community and maintainers prioritize this request
* Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
* If you are interested in working on this issue or have submitted a pull request, please leave a comment

### Description

Add two new variables, `associate_public_ip_address` and `target_ami_name_prefix`.

### Motivation

The Packer EBS Builder includes a variable to force the association of a [public IP address](https://developer.hashicorp.com/packer/plugins/builders/amazon/ebs#associate_public_ip_address) to the builder. This is needed when using a non-default VPC that does not automatically assign public IP addresses. Exposing that variable to users would be beneficial.

The `ami_name_prefix` variable is currently misleading. The description is "The prefix to use when creating the AMI name", which is accurate, but this same prefix is used to locate the source AMI when building. This means the variable cannot be changed to customize the target AMI name. We can expose a second variable that is specifically used for the target AMI name and update the `ami_name_prefix` variable to more accurately describe its use.

### References

* [https://developer.hashicorp.com/packer/plugins/builders/amazon/ebs#associate_public_ip_address](https://developer.hashicorp.com/packer/plugins/builders/amazon/ebs#associate_public_ip_address)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.