aws-samples / aws-samples/amazon-cloudwatch-container-insights
Is init container still needed?
- Dominant language
- Shell
- Stars
- 178
- Forks
- 117
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 3
Description
According to the example yaml, we need to use an init container as a workaround for some issue in the fluentd image.
https://github.com/aws-samples/amazon-cloudwatch-container-insights/blob/2ae134f544294c0be7117df5a109a22a46b421f7/k8s-deployment-manifest-templates/deployment-mode/daemonset/container-insights-monitoring/fluentd/fluentd.yaml#L364-L375
However, we are not observing any problems without this init container, and based on this issue I think this may have been fixed long ago. https://github.com/fluent/fluentd-kubernetes-daemonset/issues/161
Is this init container still needed? If not can it be removed from the example yaml?
Contributor guide
Research direction
Start with k8s-deployment-manifest-templates/deployment-mode/daemonset/container-insights-monitoring/fluentd/fluentd.yaml, especially lines 364-375, and review the linked Fluentd Kubernetes DaemonSet issue. Verify whether the init container workaround is still required with the current Fluentd image. Done means the example YAML either retains it with a documented reason or removes it when the workaround is obsolete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kubernetes
- Domain
- devops, observability-sre
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100