aws-cqc / aws-cqc/DeviceLayout.jl

Include holes in ClippedPolygon perimeter

Open
#264 0 comments 0 reactions 0 assignees View on GitHub
2.0 enhancement
Dominant language
Julia
Stars
67
Forks
14
Avg merge
1d 16h
Merged PRs (30d)
21

Description

This is documented as measuring only the outermost contours, so changing that would be breaking. I think this may have previously been used for sampling points for mesh sizing, but it seems it's not anymore, so there's nothing stopping us from choosing a more geometrically conventional definition other than the docstring.

Contributor guide

Open the contributing guide

Research direction

Start by locating the ClippedPolygon perimeter implementation and its docstring, then inspect any existing callers or tests that define perimeter behavior. The work is done when hole contours are included consistently, the documented definition matches the behavior, and relevant tests cover the changed result.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
computer-graphics
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.