aws-cloudformation / aws-cloudformation/cloudformation-pkl

Change `dbsubnetgroup.DBSubnetGroup` from `Listing<String|Mapping>` to `Listing<String|Mapping>|Mapping`

Open
#10 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Pkl
Stars
23
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Currently, it doesn't support this kind of use:
```pkl
Resources {
["SubnetGroup"] = new dbsubnetgroup.DBSubnetGroup {
// ...
SubnetIds = cfn.Ref("SubnetsIds")
// ...
}
}
```
It forces you to receive multiple subnet parameters to be passed directly in a listing, like this:
```pkl
Resources {
["SubnetGroup"] = new dbsubnetgroup.DBSubnetGroup {
// ...
SubnetIds = new Listing {
cfn.Ref("SubnetId1")
cfn.Ref("SubnetId2")
cfn.Ref("SubnetId3")
}
// ...
}
}
```
The idea is to fix it and allow using refs directly

Contributor guide

Open the contributing guide

Research direction

Locate the declaration of dbsubnetgroup.DBSubnetGroup and inspect how its SubnetIds type is defined. Compare it with the two usage examples in the issue; done means a direct cfn.Ref("SubnetsIds") assignment is accepted while the existing listing form remains supported.

Written by the indexing model from the issue text.

Assessment

Domain
cloud
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.