aws-cloudformation / aws-cloudformation/cloudformation-coverage-roadmap

Drift Detection silently failing to scan all supported resources

Open
#801 0 comments 3 reactions 0 assignees View on GitHub
enhancement
Dominant language
No language data
Stars
1.1k
Forks
62
PR merge metrics
No merged PRs in 30d

Description

## 1. Title
Drift Detection silently failing to scan all supported resources

## 2. Scope of request
I don't notice a pattern that seems like specific Resource types are affected or not, so I think the scope is ALL resources being detected for drift.

## 3. Expected behavior
I expect that every time I click on "Detect Stack Drift" or invoke `detect_stack_drift` via the API, all supported resources (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/resource-import-supported-resources.html?icmpid=docs_cfn_console) will be scanned and returned in the list of resources.

When I use the CloudFormation console for this, I see no errors that might indicate the the Drift Detection encountered an error, and the timestamps show up correctly. But the list of resources scanned will be different each time invoke drift detection again.

When I use the CloudFormation API, I actually get slightly different behavior, where some resources will specifically show errors for Rate Exceeded
```sh
Stack (arn:aws:cloudformation:REGION:ACCOUNT:stack/nodegroup-az2/UUID) failed with message: {"Summary":"Failed to detect drift on resources [NodeInstanceRoleArn,NodeDrainerPermission,NodeGroup,KubeManifestLambdaArn,NodeDrainerLambdaArn,NodeDrainerEvent]","Failures":[{"Resource":"NodeInstanceRoleArn","FailureReason":"Rate exceeded"},{"Resource":"NodeDrainerPermission","FailureReason":"Rate exceeded"},{"Resource":"NodeGroup","FailureReason":"Rate exceeded"},{"Resource":"KubeManifestLambdaArn","FailureReason":"Rate exceeded"},{"Resource":"NodeDrainerLambdaArn","FailureReason":"Rate exceeded"},{"Resource":"NodeDrainerEvent","FailureReason":"Rate exceeded"}]}
```
I'm unsure if this error message is actually related, but I wonder if the Console is running into the same error, but silently fails.

## 4. Suggest specific test cases

My CloudFormation templates are not dissimilar to the EKS quick start templates with a few more resources added. We are definitely BELOW the "max # of resources per template" so I don't think that should be a factor.

## 5. Helpful Links to speed up research and evaluation
N/A

## 6. Category (required) - Will help with tagging and be easier to find by other users to +1
This is specific to all CloudFormation resources, not specific resources.

## 7. Any additional context (optional)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.